docpad-plugin-thumbnails icon indicating copy to clipboard operation
docpad-plugin-thumbnails copied to clipboard

Incompatible with DocPad v6.80 and above

Open cattermo opened this issue 7 years ago • 7 comments

Plugin requires updating to CoffeeScript v2. This can be done automatically via running https://github.com/bevry/boundation on it. If you would like the DocPad team to do it, then transfer the repo to the https://github.com/docpad organisation, and run the following:

npm owner add balupton docpad-plugin-assets npm owner add bevryme docpad-plugin-assets

cattermo avatar Sep 24 '18 13:09 cattermo

I'm happy to transfer this, but I need permission to create repo's on the 'docpad' organisation to do so?

rantecki avatar Sep 24 '18 23:09 rantecki

FYI - I've updated the npm package owners

rantecki avatar Sep 24 '18 23:09 rantecki

Just added @rantecki to the docpad extras team, once you accept you should be able to transfer

balupton avatar Sep 25 '18 12:09 balupton

Ok, this is done.

rantecki avatar Sep 26 '18 07:09 rantecki

Great, I'll get to the upgrade with the rest of them.

balupton avatar Sep 26 '18 08:09 balupton

Sorry, I just saw this issue after fork and work upgrading this plugin. This is the repo https://github.com/fmanaya/docpad-plugin-thumbnails. I make changes from plugin template (docpad-plugin-yourpluginname) and not using boundation. Unfortunately I'am not able tu pass the tests. I think it fail first on constructor... So, after this issue, I am not sure what is the way. If you transfer and upgrade this plugin soon i can wait. If not, maybe you can give me some hint to fix it. Thank you very match

fmanaya avatar Oct 06 '18 07:10 fmanaya

I've got this plugin converted locally but got some spontaneous failing tests, more details here:

https://github.com/docpad/docpad-plugin-assets/issues/5#issuecomment-425911371

I'll have a fix out hopefully next week (requires some changes to docpad-plugintester). Got a few time critical tasks to knock off first though.

balupton avatar Oct 06 '18 09:10 balupton