docpad-plugin-partials icon indicating copy to clipboard operation
docpad-plugin-partials copied to clipboard

2.11.0 memory leak

Open paleite opened this issue 8 years ago • 2 comments

2.10.0 worked without a problem, but 2.11.0 seems to be leaking memory. Large projects can't allocate enough memory, but it works for smaller projects.

paleite avatar May 16 '17 15:05 paleite

that's strange, as the only change was an upgrade of taskgroup and extendr

taskgroup v5 should be a huge memory and performance win, which makes this strange - however, DocPad does not use it yet - the next minor version will

can you continue looking into this and post back your findings as you go - as I do not currently have the time to

balupton avatar May 17 '17 14:05 balupton

If you look at https://github.com/docpad/docpad-plugin-partials/commit/71d0d5439b588b363e0032f9f41bd2be35b541a3#diff-f720b381cf00d86a4b6cbad9f5e642c5 you can see that there's been a change in the source, too.

If I'm not mistaken, the logic is different when obj = true, but I don't know if that's on purpose or not.

paleite avatar May 18 '17 09:05 paleite