dockware icon indicating copy to clipboard operation
dockware copied to clipboard

Don't manipulate the .env file

Open shyim opened this issue 2 years ago • 7 comments

Describe the bug Dockware should always create a .env.local file instead modifying the existing .env file.

To Reproduce Try to update Shopware with the new updater

Expected behavior Dockware creates a .env.local instead modiying the existing .env

shyim avatar Mar 21 '23 13:03 shyim

I'd support this as well. Best to have a separate ".env.local" file with e.g. "APP_URL=dev" and "DATABASE_URL=..." as this file is blocked from Git via .gitignore.

sandoba avatar May 08 '23 17:05 sandoba

will come for all images 6.5 and newer with our dockware 2.0 version this week

martinweinmayr avatar May 09 '23 06:05 martinweinmayr

Using dockware/dev:6.5.8.2 and it seems that there is no .env.local there.

jkobus avatar Jan 30 '24 04:01 jkobus

yup seems still broken

shyim avatar Apr 02 '24 13:04 shyim

dockware/dev:6.0.0.1 has the same problem which crashes the system when using the updater in admin

openmindculture avatar Apr 02 '24 14:04 openmindculture

hi so the reason why theres no .env.local is because we have 3 layers - showpare - dockware - custom shop project

we are doing a few things in the prepared .env, like using 127.0.0.1 for DB instead of localhost (required somehow, but just as an example) if we would use a .env.local, then its very likely that the .env.local of the project might not have that setting which means its automatically broken, because all our settings will be immedately overwritten by the project that uses dockware

thats the reason why we are adjusting the .env instead of the .env.local

the question with the admin-updater is something else right? is there anything in the .env which is the reason why its broken? thought its a shopware problem? i think we are just using the original .env and changing a few values

boxblinkracer avatar Apr 02 '24 14:04 boxblinkracer

The alternative solution would be that you disable the auto updater with yaml config 🤔

shyim avatar Apr 02 '24 19:04 shyim