node-sdk icon indicating copy to clipboard operation
node-sdk copied to clipboard

Volumes API

Open bwateratmsft opened this issue 5 years ago • 4 comments

The new Docker CLI recently added volumes support (at least in ACI contexts). Can this SDK also add support for that? I assume it would mean new protos for volumes.

bwateratmsft avatar Sep 22 '20 17:09 bwateratmsft

Yes it's in our plans, a Volume API for ACI contexts should arrive soon here

gtardif avatar Sep 23 '20 13:09 gtardif

cc @ulyssessouza

gtardif avatar Sep 23 '20 13:09 gtardif

Looks like implementation in #43 is good. The Edge channel does not yet have ACI integration 0.1.18; is there something newer I can test with or should I just hold off for now?

bwateratmsft avatar Sep 29 '20 15:09 bwateratmsft

@gtardif said in an email:

we just released node-sdk v0.1.18 This includes APIs for volume management (list, create, delete) on ACI. It will require the docker ACI integration 0.1.18, coming with Docker Desktop 2.4.0.0 (Desktop stable)

So sounds like we should only enable the feature if the user has Desktop 2.4.0.0 or newer

karolz-ms avatar Sep 29 '20 16:09 karolz-ms