Add automated checks for two LGTM rule.

Open cyphar opened this issue 9 years ago • 1 comments

Both Docker and opencontainers projects have the same set of rules for merging. We should add some checks to Gordon so that it harasses maintainers who merge code without it having two LGTMs (as well as adding a comment while there are still LGTMs missing).

Preferably Gordon would also check that the isn't any self-LGTMs (opencontainers/project-template#13).

This allows us to do more management of our respective projects without needing to use a proprietary tool (PullApprove).

May 27 '16 03:05 cyphar

So two feature requests:

Require 2 LGTM (or allow this to be configurable)
Don't accept self-LGTM

These sound reasonable to me. Do you want to submit a patch for not accepting self-lgtm? Devs can always "merge --force" so it shouldn't block people on tiny projects.

For requiring multiple lgtm, we should work out a way to make this configurable. I'll spend some time thinking about how to do this. One option might be to have a .gordon config file to make this configurable. Suggestions are welcome.

Jun 02 '16 15:06 fkautz