docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Allow container name property from sparse list

Open stuartthomson opened this issue 5 years ago • 3 comments

The 'name' property for a container is currently assumes there is a 'Name' attribute on the object returned by the API call. This works when the container was created with an 'inspect' API call, but if it comes from a list containers call the name is not found. The docker docs indicate that containers listed this way have no 'Name' attribute, and instead have 'Names'. As far as I can tell there can only ever be one of these, so taking the first element of the list seems fine.

stuartthomson avatar Aug 04 '20 18:08 stuartthomson

Wondering if any maintainers have a chance to look at this? @ulyssessouza @aiordache (not sure if you are the right people to ping, apologies if not!)

stuartthomson avatar Aug 24 '20 10:08 stuartthomson

Wondering if there was any update on this? I addressed the review comments.

Thanks!

stuartthomson avatar Sep 25 '20 12:09 stuartthomson

@ulyssessouza @aiordache Just wondering on the status of this PR?

stuartthomson avatar Feb 09 '21 17:02 stuartthomson