docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Resolve issue: #2413, add --cpus to docker update method

Open pkruk opened this issue 6 years ago • 3 comments

Hi,

In this patch I've added a missing missing '--cpu' parameter for a docker update command.

I followed the docker documentation: https://docs.docker.com/engine/api/v1.29/#operation/ContainerCreate and PR: https://github.com/moby/moby/pull/31148/files

This PR should solve a issue: https://github.com/docker/docker-py/issues/2413

pkruk avatar Aug 25 '19 14:08 pkruk

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "feature/docker_update" [email protected]:pkruk/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Aug 25 '19 14:08 GordonTheTurtle

@shin- Thanks for a review! I will update my PR today :)

pkruk avatar Aug 27 '19 08:08 pkruk