docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Add support of DOCKER_API_VERSION env variable

Open Matzz opened this issue 7 years ago • 4 comments

Matzz avatar Sep 21 '18 22:09 Matzz

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "master" [email protected]:Matzz/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Sep 21 '18 22:09 GordonTheTurtle

I'd like to have that. Are you planning to finish this up @Matzz / @onzo-mateuszzakarczemny ? Otherwise can I pick it up?

little-dude avatar Dec 12 '18 16:12 little-dude

I'd like to have that. Are you planning to finish this up @Matzz / @onzo-mateuszzakarczemny ? Otherwise can I pick it up?

Hi. Sorry I forgot about this PR. I had some issues with make it working and did some workaround instead of finishing that. Feel free to pick it if you want.

onzo-mateuszzakarczemny avatar Dec 13 '18 11:12 onzo-mateuszzakarczemny

@little-dude Are you interested in fixing this? (Or anyone else) For that you just need to rebase with master to make it pass the CI and fix the comment as suggested by @TomasTomecek in Please rebase the PR with master to make it pass the CI

ulyssessouza avatar Apr 04 '19 14:04 ulyssessouza