docker-credential-helpers icon indicating copy to clipboard operation
docker-credential-helpers copied to clipboard

Enabled ppc64le as an architecture

Open vrushaliinamdar opened this issue 6 years ago • 4 comments

Enabled ppc64le under "arch" instead of specifying under "os" arch: - ppc64le

vrushaliinamdar avatar Jan 22 '20 14:01 vrushaliinamdar

Hi Team,

Could you please comment on this request?

vrushaliinamdar avatar Jan 29 '20 08:01 vrushaliinamdar

Hi @vrushaliinamdar -- this is a dup of https://github.com/docker/docker-credential-helpers/issues/144. Have you considered submitting a PR for this update yourself? We know that this project does build easily on ppc64le.

clnperez avatar May 26 '20 21:05 clnperez

I don't think this change currently does what it was intended to do, because now it only runs on ppc64le, so looks like more changes are needed;

Screenshot 2021-01-20 at 10 59 17

thaJeztah avatar Jan 20 '21 10:01 thaJeztah

@thaJeztah ok to close this? you're right -- this PR does only build for power, whereas before it already built power binaries, but they aren't being published.

clnperez avatar Nov 29 '21 15:11 clnperez

We enabled cross-builds for s390x and ppc64le in https://github.com/docker/docker-credential-helpers/pull/227

thaJeztah avatar Aug 20 '22 19:08 thaJeztah