containerd-packaging icon indicating copy to clipboard operation
containerd-packaging copied to clipboard

containerd.io package naming is missing the distribution

Open devopstt opened this issue 3 years ago • 2 comments

Hi,

we are using APTLY to mirror download.docker.com to our internal APT mirror. Recently we ran into this issue https://github.com/aptly-dev/aptly/issues/1036

The error we got:

ERROR: unable to publish: unable to process packages: error linking file to /opt/mirror/public/3rdparty/2022-03-15/pool/main/c/containerd.io/containerd.io_1.5.10-1_amd64.deb: file already exists and is different

The files are indeed different but have the same name for bionic and focal (same for jammy and all other releases). https://download.docker.com/linux/ubuntu/dists/focal/pool/stable/amd64/containerd.io_1.5.10-1_amd64.deb https://download.docker.com/linux/ubuntu/dists/bionic/pool/stable/amd64/containerd.io_1.5.10-1_amd64.deb

The package name does not inlcude the debian_revision what leads to duplicate package names.

For all the other packages the naming is fine, like for docker-ce-cli, because it includes the debian_revision

docker-ce-cli_20.10.13~3-0~ubuntu-jammy_amd64.deb

https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-version As it is recommended by Debian to add the debian_revision, could you add it to future releases, please?

devopstt avatar Jan 02 '23 11:01 devopstt

Thanks for reporting; this is similar to / related to https://github.com/docker/for-linux/issues/1315

I noticed this as well, and we probably need changes similar to https://github.com/docker/docker-ce-packaging/pull/701 (https://github.com/docker/docker-ce-packaging/pull/701/commits/f8299f20216a4e2def617f7d3605eab1d68132ee) for the containerd packages as well.

the build-scripts for containerd packages are in a separate repository (https://github.com/docker/containerd-packaging); let me transfer this ticket to that repository's issue tracker.

thaJeztah avatar Jan 04 '23 09:01 thaJeztah

Hi @thaJeztah - thanks for linking my issue "Different checksum..." to this project. Do you roughly know when this could be implemented? Thanks!

tirolerstefan avatar Aug 08 '24 13:08 tirolerstefan