compose-switch icon indicating copy to clipboard operation
compose-switch copied to clipboard

Remove problematic backticks in the install script

Open fredngo opened this issue 3 years ago • 2 comments

Backticks will try to execute the string within as a command, but docker-compose may not yet exist at this point, and it seems to be the original intention to simply display information, not run the docker-compose command

fredngo avatar Jun 15 '22 15:06 fredngo

LGTM

Thank you @BBaoVanC, please review PR https://github.com/docker/compose-switch/pull/31 as well?

Not my PR but provides the rest of the fix for issue https://github.com/docker/compose-switch/issues/33

(For what it's worth the fix in https://github.com/docker/compose-switch/pull/31 runs well in my own server environment.)

fredngo avatar Jun 21 '22 13:06 fredngo

LGTM

Thank you @BBaoVanC, please review PR #31 as well?

Not my PR but provides the rest of the fix for issue #33

(For what it's worth the fix in #31 runs well in my own server environment.)

I'll take a look if I have some time, but right now I don't have a good system I'm comfortable experimenting on.

BBaoVanC avatar Jun 21 '22 20:06 BBaoVanC

This was subsequently fixed in 2882394023ddee9e34532c8033ea3be3471c844d

fredngo avatar Aug 24 '22 21:08 fredngo