compose-cli icon indicating copy to clipboard operation
compose-cli copied to clipboard

docker compose can't change FirelensConfiguration/LogConfiguration

Open nobiit opened this issue 3 years ago • 4 comments

Description

  • Current code makes it impossible to change FirelensConfiguration.
  • I can't customizeLogConfiguration with ecs-compose.yml

Describe the results you received:

  • FirelensConfiguration is always nil
  • LogConfiguration always uses awslog, I want to use another service, for example awsfirelens

Describe the results you expected:

  • FirelensConfiguration can be changed with x-aws-cloudformation or a new parameter like x-aws-firelens-configuration
  • LogConfiguration can be changed with x-aws-cloudformation or a new parameter like x-aws-log-configuration

Additional information you deem important (e.g. issue happens only occasionally):

  • Viewing logs on ECS is inconvenient, I need to push logs through other services like Loki of Grafana to be able to manage logs centrally
  • https://github.com/docker/compose-cli/blob/main/ecs/convert.go#L124
  • https://github.com/docker/compose-cli/blob/main/ecs/convert.go#L334-L336

nobiit avatar Feb 25 '22 02:02 nobiit

Hey @nobiit Looking for some input for https://github.com/compose-x/ecs_composex/issues/600, i.e. how you'd like to be able to configure either everything, or having "shortcuts" settings that will generate the CFN config for the task definitions etc. automatically? Thanks a lot in advance :medal_sports:

JohnPreston avatar May 10 '22 17:05 JohnPreston

@nobiit I'am in the final phases of testing x-logging.FireLens (and logging.driver awsfirelens etc.). I used the following to do all the testing and created a git repo just to go over the examples: https://github.com/compose-x/compose-x-firelens-examples

Anything in there not here you'd like to "see" ? Cheers,

JohnPreston avatar Jun 01 '22 07:06 JohnPreston

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 08 '23 04:01 stale[bot]

This issue has been automatically closed because it had not recent activity during the stale period.

stale[bot] avatar Jun 18 '23 19:06 stale[bot]