Codecov Report

Merging #3662 (3a75f29) into master (247f568) will decrease coverage by 0.04%. The diff coverage is 37.20%.

:exclamation: Current head 3a75f29 differs from pull request most recent head 1b827ae. Consider uploading reports for the commit 1b827ae to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
- Coverage   59.21%   59.17%   -0.05%     
==========================================
  Files         288      288              
  Lines       24605    24647      +42     
==========================================
+ Hits        14571    14586      +15     
- Misses       9159     9176      +17     
- Partials      875      885      +10

Jun 06 '22 16:06 codecov-commenter

I think this is important to get into 22.06

Jun 28 '22 21:06 s4ke

@thaJeztah I think this should be merged. Happy to help with anything regarding CSI support in Swarm Mode.

Sep 27 '22 18:09 s4ke

I think there's two changes needed for this to be merged;

As we discussed in a maintainers call (and because the syntax may still change), change this option to an -x- option (perhaps -x-cluster-volume ?
We need to update this PR to take into account the changes from csi to cluster

@dperny do you have time to work on that, to get it merged?

Oct 06 '22 18:10 thaJeztah

Seems like on this one we just need the x- change?

Oct 27 '22 18:10 cpuguy83

There is a problem with the expectedConfig.Volumes in the test run results. Is there an additional change needed to go with the "spec" vs "x-cluster-spec" change?

Nov 02 '22 15:11 sam-thibault

Yeah, I was just missing a struct tag for mapstructure so things weren't parsing out correctly. Should be fixed now.

Nov 02 '22 16:11 dperny

Add compose support for cluster volumes

Codecov Report