docker
fixes #617: change delimeter for nodeselector
As described in #617, there is a conflict between the comma splitting labels and driver opts
That would be possible if the quotation marks were kept inside the driverOpt parameter value. As far as I know, buildx is not even aware of the quotation marks as these are removed in bash before buildx runs.
bin/buildx create --driver kubernetes --name buildx --driver-opt "replicas=3,nodeselector='label1=value1,label2=value2,namespace=5'"
would do the job, but I feel like using ; is more convenient.
@MichalAugustyn since this PR was opened, we've updated the kubernetes driver docs https://docs.docker.com/build/drivers/kubernetes/#node-assignment:
Due to quoting rules for shell commands, you must wrap the nodeselector and tolerations parameters in single quotes. You can even wrap all of --driver-opt in single quotes, ...
Does that help resolve the issue? If not, we should probably try and work out what to do with this PR.
