buildx icon indicating copy to clipboard operation
buildx copied to clipboard
verified publisher icon docker

CLI: In a terminal with a dark background, the output is difficult to read.

Open niftyhack opened this issue 4 years ago • 2 comments

  • [x] I have tried with the latest version of Docker Desktop
  • [ ] I have tried disabling enabled experimental features
  • [x] I have uploaded Diagnostics
  • Diagnostics ID: F422FCD1-9103-499F-B66B-A21B08AF9789/20210419073651 (uploaded)

Expected behavior

I don't know since when this change has been in place, but in the past the output text was either not coloured or coloured in such a way that it was easily readable even in a terminal with a dark background.

Actual behavior

In a terminal with a dark background, some output is difficult to read (dark blue, dark grey), e.g. in docker build. A screenshot: https://imgur.com/a/QSH3l1Y

Information

  • macOS Version: Catalina 10.15.7 (19H114)
  • Intel chip or Apple chip:
  • Docker Desktop Version: 20.10.5, build 55c4c88 (reinstalled via homebrew today)
  • Terminal is iTerm2 Build 3.3.9

niftyhack avatar Apr 19 '21 07:04 niftyhack

Hi, first of all sorry for digging up this issue, this is just the only open one that I could find.

Text is still dark blue and illegible in Linux terminals with a black background. Could it be an issue with Docker Compose v2.5.0 itself or is this still in need of being resolved?

svenmauch avatar May 24 '22 07:05 svenmauch

This is an accessibility issue, since it happens when Dark Mode is enabled (which is a macOS accessibility feature). Wanted to make sure this wasn't overlooked, sorry for the ping @crazy-max. What needs to happen for this to be resolved?

Also, am I correct that the change made for the related issue #560 is to turn off colored output? That seems like that removes the "different colored lines for for different containers" feature entirely for Dark Mode users. Would it instead be possible to use a different list of colors when the OS equivalent of Dark Mode is enabled?

nk9 avatar Jul 07 '22 10:07 nk9

Hi,

just wondering - the same is happening in the default Terminal app on Mac OS when using some of the dark themes - for example, the very popular green-on-black theme called Homebrew. This happening regardless of the OS theme.

petrklus avatar Sep 22 '22 12:09 petrklus

This has been fixed since Buildx v0.9.0 with BUILDKIT_COLORS and NO_COLOR env vars: https://github.com/docker/buildx/blob/v0.9.0-rc1/docs/guides/color-output.md

$ BUILDKIT_COLORS="run=123,20,245:error=yellow:cancel=blue:warning=white" docker buildx build .
$ NO_COLOR=1 docker buildx build .

crazy-max avatar Sep 22 '22 14:09 crazy-max

Is there any ticket or plan to e.g. leverage COLORFGBG or provide a default for terminals with dark background?

deepskyblue86 avatar Jan 31 '24 14:01 deepskyblue86