rpm package is incomplete

[glensc]

https://github.com/docker/dockercloud-agent/blob/v1.1.0/contrib/make-rpm.sh

after looking the contents i noticed bunch of debian specific things that are likely unhandled for redhat systems:

• post/pre-inst scripts will never do anything because $1 are numeric
• redhats never went for upstart, afaik only one version of fedora had upstart
• _dh_action is likely undefined
• #DEBHELPER# is noop
• postrm is never do anything due wrong $1 comparision
• postinst $2 check is incorrect, should be again $2 = 2 to ensure upgrade, not first install
• prerm $1 check also wrong, should be $1 = 0 to check uninstall otherwise you be stopping it on upgrades!
• shared library depends like --depends libc.so.6 are pointless because rpmbuild generates them, and incorrect because they lack x86_64 specifier. not sure about fpm
• --provides dockercloud-agent / --replaces dockercloud-agent is dumb, it's default behaviour of rpm to upgrade packages by same name.

as i read from your pull-request/tickets this tool will become soon obsolete, i did not bother to send PR, at least write Issue so you can decide yourself. i don't use redhat/rhel/fedora either so i'm no good tester.

[glensc]

also: logrotate config has usless sharedscripts directive. it has no scripts in it, so the line can be dropped