Fixing Travis CI and use go 1.10 and later versions

[xinfengliu]

• Need to upgrade go 1.10 and later to fix "go get -u github.com/golang/lint/golint" error in travis CI. See: https://github.com/golang/lint/issues/421

• Also modify integration test code to make it pass the CI when using golang 1.10.x.

• Replace "github.com/golang/lint/golint" with "golang.org/x/lint/golint" (This is needed for golang 1.12 or later)

• Modify Makefile to fix make test error when using go 1.12 or later.

Signed-off-by: Xinfeng Liu [email protected]

[thaJeztah]

could you either squash the first two commits, or swap their order? If the second commit is needed to fix CI for changes due to updating to Go 1.10, it should either be there first commit, or go together with the actual change to update to Go 1.10 (otherwise Git bisect would be broken)

[xinfengliu]

@thaJeztah , thanks. I squshed the commits. However, I could not make go 1.12 or 1.13 work, make test failed at go test -bench=. :

FAIL	github.com/containerd/containerd/runtime [build failed]
FAIL	github.com/containerd/containerd/supervisor [build failed]

Without -bench=., make test could pass. I don't know why.

[xinfengliu]

The culprit is github.com/containerd/containerd/api/http/pprof. There is no test or benchmark method in that package, so it's safe to take this package out of go test.

[thaJeztah]

Two failures on tip. First one is interesting. (not a blocker, because it's tip, but curious what changed).

I kicked CI once more to see if it was just an intermittent failure

FAIL: start_linux_test.go:522: ContainerdSuite.TestSigkillShimReuseName
855
856start_linux_test.go:556:
857    t.Assert(*e, checker.Equals, evt)
858... obtained types.Event = types.Event{Type:"exit", Id:"top", Status:0xff, Pid:"init", Timestamp:(*timestamp.Timestamp)(0xc0002ded90)}
859... expected types.Event = types.Event{Type:"exit", Id:"top", Status:0x89, Pid:"init", Timestamp:(*timestamp.Timestamp)(0xc0002ded90)}
860
861
862----------------------------------------------------------------------
863FAIL: start_linux_test.go:569: ContainerdSuite.TestSigkillShimWhileContainerIsPaused
864
865start_linux_test.go:577:
866    t.Fatal(err)
867... Error: rpc error: code = 2 desc = oci runtime error: container with id exists: top