Dnn.Platform icon indicating copy to clipboard operation
Dnn.Platform copied to clipboard

[Bug]: The number of members of a role group is not always displayed correctly.

Open meffj00 opened this issue 1 year ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

What happened?

The number of members of a role group is not always displayed correctly.

Steps to reproduce?

  1. Log in as Administrator
  2. Goto the admin Personabar and select Roles
  3. The number of members of a role group is not always displayed correctly.

Current Behavior

The number of members of a role group should be always displayed correctly.

Expected Behavior

The number of members of a role group should be always correctly.

Relevant log output

No response

Anything else?

No response

Affected Versions

9.13.2 (latest release)

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

meffj00 avatar Mar 07 '24 16:03 meffj00

I think this is the actual situation:

  • When a user is deleted (but exsiting in the basket), he is still member of the group and counted. You can say that this is Correct because the user is visible in the Grouplist too.
  • When the membership is expired (end date), the user is even listed but NOT counted anymore.

==> Only active members are counted, but there is some inconsitency. If you do not count expired accounts, than you should also not count the 'soft deleted' users.

So, it is nog a bug, but an inconsitency. It can be solved:

  • explane the count column (users = active users) AND change code so it do not count deleted users (and not expired users).

aspelt avatar Apr 11 '24 17:04 aspelt

I'm talking about the membership of roles, not users. In my opinion it doesn't matter, you are a member of a role or not. With users I totally agree with you!

Met vriendelijke groet,

Jan Meffert 06-54300535


From: Ad Spelt @.> Sent: Thursday, April 11, 2024 7:49:04 PM To: dnnsoftware/Dnn.Platform @.> Cc: Jan Meffert @.>; Author @.> Subject: Re: [dnnsoftware/Dnn.Platform] [Bug]: The number of members of a role group is not always displayed correctly. (Issue #5995)

I think this is the actual situation:

  • When a user is deleted (but exsiting in the basket), he is still member of the group and counted. You can say that this is Correct because the user is visible too in the Grouplost
  • When the membership is expired (end date), the user is even listed but NOT counted anymore.

==> Only active members are counted, but there is some inconsitency. If you do not count expired accounts, than you should also not count the 'soft deleted' users.

So, it is nog a bug, but an inconsitency. It can be solved:

  • explane the count column (users = active users) AND change code so it do not count deleted users (and not expired users).

— Reply to this email directly, view it on GitHubhttps://github.com/dnnsoftware/Dnn.Platform/issues/5995#issuecomment-2050201647, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC4HRXF6HRGU2XUHDORQSMDY43EI7AVCNFSM6AAAAABELI6BGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGIYDCNRUG4. You are receiving this because you authored the thread.Message ID: @.***>

meffj00 avatar Apr 16 '24 20:04 meffj00

I think we talk about the same. I did some research/testing to find out the cause of the problem. The issue is that not all Members in a role are counted. The cause is that expired memberships are not counted but still listed. In my opinion that explains the difference.

A very Dutch 'groet',

Ad

aspelt avatar Apr 17 '24 19:04 aspelt