dgl icon indicating copy to clipboard operation
dgl copied to clipboard

[GraphBolt] Fix `blocks` in minibatch when facing with empty edges in subgraph.

Open yxy235 opened this issue 1 year ago • 5 comments

Description

related to #7410

TODO:

  1. add test case: get blocks from homo graph minibatch
  2. add test case: check if node type of seeds still occurs in src_node_type of edges, it will always be passed down.

Checklist

Please feel free to remove inapplicable items for your PR.

  • [ ] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • [ ] I've leverage the tools to beautify the python and c++ code.
  • [ ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • [ ] All changes have test coverage
  • [ ] Code is well-documented
  • [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • [ ] Related issue is referred in this PR
  • [ ] If the PR is for a new model/paper, I've updated the example index here.

Changes

yxy235 avatar May 16 '24 05:05 yxy235

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch]; For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

dgl-bot avatar May 16 '24 05:05 dgl-bot

Commit ID: 2e7b62e10858fab34a46226c62ccfe849cd5e30d

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar May 16 '24 05:05 dgl-bot

Commit ID: 2bd775c0b3768f5071bb34818e23d954ca7dd9f7

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar May 16 '24 06:05 dgl-bot

Commit ID: ddb12da24356dcfe459e512cefe09b4eeddae6c1

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar May 16 '24 07:05 dgl-bot

Commit ID: a382232b5c0270e6fba9f4aace34d2542dd7094b

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar May 16 '24 10:05 dgl-bot

@Skeleton003 please work on this PR. the code change in python core is done. you just need to add more testcases, just cover all possible scenarios we may hit. Please refer to the description for the issue this PR is targeting on.

TODO:

add test case: get blocks from homo graph minibatch
add test case: check if node type of seeds still occurs in src_node_type of edges, it will always be passed down.

Rhett-Ying avatar Jun 03 '24 03:06 Rhett-Ying

Commit ID: a1875a124bdc1295a51cdb4b18d479e1cc25f104

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot avatar Jun 08 '24 07:06 dgl-bot

Commit ID: d98f5d7724894240439d32625482e6a19e72dae2

Build ID: 6

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

dgl-bot avatar Jun 08 '24 07:06 dgl-bot

Commit ID: b04c7db27970c4a046765c1ae496180152d9f0de

Build ID: 7

Status: ❌ CI test failed in Stage [Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Jun 09 '24 07:06 dgl-bot

Commit ID: 2decac0bc73b246693ff29fde0b67ccd9f1690c6

Build ID: 8

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Jun 09 '24 16:06 dgl-bot

Commit ID: e5d9daabbf0d7a2a5409e70730364e91588926dd

Build ID: 9

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Jun 10 '24 05:06 dgl-bot

Commit ID: 27d5eca9d95dc4fba7ed856e70925a6fb97bfecf

Build ID: 10

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Jun 11 '24 07:06 dgl-bot

Commit ID: 84af1961300de732149f71c3f698ef565b9284d6

Build ID: 11

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Jun 12 '24 21:06 dgl-bot

Commit ID: 546891d03db6cd841b4b3fc5f6dd2e157c962a27

Build ID: 12

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

dgl-bot avatar Jun 13 '24 07:06 dgl-bot

Commit ID: 85b2cb598486990593314ccecdd9462e68e52c3d

Build ID: 13

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Jun 13 '24 08:06 dgl-bot

@dgl-bot

Rhett-Ying avatar Jun 13 '24 09:06 Rhett-Ying

Commit ID: 85b2cb598486990593314ccecdd9462e68e52c3d

Build ID: 14

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

dgl-bot avatar Jun 13 '24 09:06 dgl-bot