MXNet.jl icon indicating copy to clipboard operation
MXNet.jl copied to clipboard

autograd: user custom function

Open iblislin opened this issue 8 years ago • 4 comments

  • an example included: examples/autograd/customfunc.jl

@vchuravy Could you review the GC-related part of this PR?

TODO:

  • [x] support where syntax for @custom

iblislin avatar Dec 18 '17 12:12 iblislin

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0fba766). Click here to learn what that means. The diff coverage is 91.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #385   +/-   ##
=========================================
  Coverage          ?   71.28%           
=========================================
  Files             ?       28           
  Lines             ?     2114           
  Branches          ?        0           
=========================================
  Hits              ?     1507           
  Misses            ?      607           
  Partials          ?        0
Impacted Files Coverage Δ
src/MXNet.jl 100% <ø> (ø)
src/base.jl 36.55% <100%> (ø)
src/autograd.jl 95.96% <91.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fba766...d11ab20. Read the comment docs.

codecov-io avatar Dec 18 '17 13:12 codecov-io

ready for review

iblislin avatar Dec 23 '17 16:12 iblislin

Any idea what's going wrong with GitHub's triple quote detection such that it thinks the whole autograd.jl is quoted? In any case this is pretty cool -- something I'd assumed was impossible, and something (fast custom native functions in the frontend's language!) that the Python frontend can never, ever offer.

jekbradbury avatar Dec 24 '17 00:12 jekbradbury

Any idea what's going wrong with GitHub's triple quote detection such that it thinks the whole autograd.jl is quoted?

It was an issue of JuliaEditorSupport/atom-language-julia, and fixed in latest release. Just waiting github upgrade their dependency. See: https://github.com/github/linguist/issues/3950

iblislin avatar Dec 24 '17 04:12 iblislin