Denis Malinovsky

Results 48 comments of Denis Malinovsky

> The same story when the reader opens a page first time (I can see desktop parts in the background) This particular issue is fixed with https://github.com/koreader/koreader-base/pull/1752. As for the...

> It can be forced enabled, to see how it would look/work with: @poire-z, it's a great addition, thank you very much! Do you think it's possible to convert it...

Something like this, perhaps? https://gist.github.com/dmalinovsky/69fd68af7848008b1cc80a76961f2d77 ```lua local ReaderPageMap = require("apps/reader/modules/readerpagemap") local postInit_orig = ReaderPageMap._postInit ReaderPageMap._postInit = function(self) self.ui.document:buildSyntheticPageMapIfNoneDocumentProvided(1818) -- Run original code postInit_orig(self) end ``` I tested it on my...

@poire-z, can you perhaps add a "user patch available" label for this one? Or whatever the label's name is.

> Do I need to set this file (.lua) in folder koreader/patches? Or do I need to do something more? Can you explain how to install this patch? Yes, just...

> how hard would it be to add this in the menu? It'll be visible in the menu if you add this patch (or your ePub has logical page numbers...

> And how you ended up chosing your value. I used a particular way to convert so called "author pages" into printed pages. This is specific to [Russian books](https://ru.wikipedia.org/wiki/%D0%90%D0%B2%D1%82%D0%BE%D1%80%D1%81%D0%BA%D0%B8%D0%B9_%D0%BB%D0%B8%D1%81%D1%82#:~:text=%D0%9A%D0%B0%D0%BA%20%D0%BF%D1%80%D0%B0%D0%B2%D0%B8%D0%BB%D0%BE%2C%20%D0%BE%D0%B4%D0%B8%D0%BD%20%D0%B0%D0%B2%D1%82%D0%BE%D1%80%D1%81%D0%BA%D0%B8%D0%B9%20%D0%BB%D0%B8%D1%81%D1%82,%D0%B8%20%D0%BE%D1%82%D0%BE%D0%B1%D1%80%D0%B0%D0%B6%D0%B0%D0%B5%D0%BC%D1%8B%D1%85%20%D0%B2%20%D1%82%D0%B5%D0%BA%D1%81%D1%82%D0%BE%D0%B2%D0%BE%D0%BC%20%D1%80%D0%B5%D0%B4%D0%B0%D0%BA%D1%82%D0%BE%D1%80%D0%B5.), and...

> So you already have set page number as for PocketBook? Don't I need to change anything? Well, the numbers won’t match identically, Pocketbook does some calculations for the pages...

> So more kludge, more if/elseif/else branches, more stuff that we will forget to test.... I think this deserves refactoring, so instead of if/else one would just call service methods...

Nice, thanks a lot, @poire-z! I'll check it out later.