dlang
Clearer "Failed output"
Thanks for your pull request and interest in making D better, @ccmywish! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:
- My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
- My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
- I have provided a detailed rationale explaining my changes
- New or modified functions have Ddoc comments (with
Params:andReturns:)
Please see CONTRIBUTING.md for more information.
If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.
Bugzilla references
Your PR doesn't reference any Bugzilla issue.
If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
Testing this PR locally
If you don't have a local development environment setup, you can use Digger to test this PR:
dub run digger -- build "master + tools#455"
Ideally we would use something like escapeShellCommand so that the output is still unambiguous (and can be copy-pasted into a shell to maybe reproduce the problem).
But... why is gcc being run with DMD's parameters? Why is there a backslash? This raises questions.
Haha, I'm forking rdmd to build a rgcc to quickly run gcc or clang on my Windows.
Yes, this is what I want: When I'm not familiar with rdmd/rgcc's own options (especially as a D beginner), there's a chance I want to check and directly copy the Failed output what rdmd/rgcc internally does, and try to run it quickly to know what is wrong.
Ideally we would use something like escapeShellCommand
https://github.com/dlang/phobos/pull/8684