phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Correct documentation.

Open veelo opened this issue 1 year ago • 1 comments

Without the cast recent compilers complain with

Error: none of the overloads of `sharedLog` are callable using argument types `(FileLogger)`
        Candidates are: `std.logger.core.sharedLog()`
                        `std.logger.core.sharedLog(shared(Logger) logger)`

veelo avatar Apr 30 '24 20:04 veelo

Thanks for your pull request and interest in making D better, @veelo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23487 regression std.experimental.logger assigning FileLogger to sharedLog no longer works

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8995"

dlang-bot avatar Apr 30 '24 20:04 dlang-bot

The shared cheats have been moved into the logger implementation by Átila, so that user code can follow proper shared practices, which is now documented.

I noted that stable has entered beta state, let me know if I should rather target master.

veelo avatar Jul 20 '24 20:07 veelo