phobos icon indicating copy to clipboard operation
phobos copied to clipboard

Add more tests w.r.t. noreturn to std.exception

Open MoonlightSentinel opened this issue 4 years ago • 2 comments

A byproduct of the recent bugfixes.

MoonlightSentinel avatar Oct 14 '21 10:10 MoonlightSentinel

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8274"

dlang-bot avatar Oct 14 '21 10:10 dlang-bot

@MoonlightSentinel this seems to have exposed an ICE:

dmd: src/dmd/backend/cod1.d:4056: Assertion `retregs || !*pretregs' failed.

RazvanN7 avatar Oct 19 '21 08:10 RazvanN7