druntime icon indicating copy to clipboard operation
druntime copied to clipboard

Make encode reusable in Phobos

Open edi33416 opened this issue 7 years ago • 2 comments

This PR adds two overloads to encode so those can be called from std.utf.encode (see here)

This PR depends on #2403

edi33416 avatar Dec 11 '18 13:12 edi33416

Thanks for your pull request and interest in making D better, @edi33416! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2404"

dlang-bot avatar Dec 11 '18 13:12 dlang-bot

@edi33416 Are you willing to take this to the finish line?

RazvanN7 avatar Nov 05 '21 07:11 RazvanN7