dmd icon indicating copy to clipboard operation
dmd copied to clipboard

Extract `include` func to dsymbolsem

Open dchidindu5 opened this issue 1 year ago • 3 comments

public bool addisdone = false; /// true if members have been added to scope
public bool onStack = false;

This variables were private before I had to change it to public because I encountered errors like undefined identifier onStack and addisdone`

Still working on them though

dchidindu5 avatar Oct 07 '24 14:10 dchidindu5

Thanks for your pull request and interest in making D better, @dchidindu5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16970"

dlang-bot avatar Oct 07 '24 14:10 dlang-bot

can it be casted? e.gLine 7539- cast(void) cache;

what about return null ? e.g line 7535 Can it be removed entirely or to be casted? @thewilsonator

dchidindu5 avatar Oct 08 '24 15:10 dchidindu5

What's the appropriate way to cast this return condition.include(cdc._scope ? cdc._scope : sc) ? decl : cdc.elsedecl;

dchidindu5 avatar Oct 11 '24 00:10 dchidindu5

Looking good! You will need to update dmd/compiler/src/tests/cxxfrontend.cc:

home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc: In member function ‘virtual void MiniGlueVisitor::visit(TypeStruct*)’:
/home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc:795:35: error: ‘class AttribDeclaration’ has no member named ‘include’
  795 |                     (void)attrib->include(NULL);
      |                                   ^~~~~~~
/home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc: In member function ‘virtual void MiniGlueVisitor::visit(TypeClass*)’:
/home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc:857:35: error: ‘class AttribDeclaration’ has no member named ‘include’
  857 |                     (void)attrib->include(NULL);
      |                                   ^~~~~~~
/home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc: In member function ‘virtual void MiniGlueVisitor::visit(AttribDeclaration*)’:
/home/runner/work/dmd/dmd/dmd/compiler/src/tests/cxxfrontend.cc:1237:27: error: ‘class AttribDeclaration’ has no member named ‘include’
 1237 |         Dsymbols *ds = d->include(NULL);

thewilsonator avatar Oct 24 '24 07:10 thewilsonator

Thank you all, over to the next

dchidindu5 avatar Oct 26 '24 00:10 dchidindu5