libdparse
libdparse copied to clipboard
dlang-community
interpolated strings, v2
better implementation, doing all the tokenizing at the start, an interpolated string being multiple tokens
requires no further changes in DCD to support with auto-completion, probably also going to just work with D-Scanner and serve-d
supersedes #508
implementation for DIP1036e
✅ PR OK, no changes in deprecations or warnings
Total deprecations: 0
Total warnings: 0
Build statistics:
------ libdparse statistics ------
statistics (-before, +after)
-library size=3163068 libdparse.a
+library size=3197196 libdparse.a
rough build time=16s
------ DCD statistics ------
statistics (-before, +after)
client size=1048544 bin/dcd-client
-server size=3089912 bin/dcd-server
+server size=3115384 bin/dcd-server
rough build time=74s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.57
-DCD run_tests.sh Maximum resident set size (kbytes): 45216
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.43
+DCD run_tests.sh Maximum resident set size (kbytes): 41324
short requests: (230x)
- min request time = 0.009ms
- 10th percentile = 0.123ms
- median time = 0.431ms
- 90th percentile = 0.747ms
- max request time = 2.228ms
+ min request time = 0.013ms
+ 10th percentile = 0.116ms
+ median time = 0.434ms
+ 90th percentile = 0.753ms
+ max request time = 1.557ms
long requests over 10ms: (51x)
- min request time = 17.360ms
- 10th percentile = 17.650ms
- median time = 18.672ms
- 90th percentile = 21.157ms
- max request time = 30.142ms
+ min request time = 16.499ms
+ 10th percentile = 17.705ms
+ median time = 18.483ms
+ 90th percentile = 20.505ms
+ max request time = 29.069ms
top 5 GC sources in server:
bytes allocated, allocations, type, function, file:line
78109696 843 void[] std.array.Appender!(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;")[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
15257216 476788 void[] core.lifetime._d_newitemT!(Data)._d_newitemT /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/druntime/import/core/lifetime.d:2833
14316800 164422 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
9773344 305417 Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
7372208 281 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../../.dub/packages/msgpack-d/1.0.4/msgpack-d/src/msgpack/common.d:628
Full build output
DUB version 1.34.0, built on Oct 15 2023
LDC - the LLVM D compiler (1.35.0):
based on DMD v2.105.2 and LLVM 16.0.6
built with LDC - the LLVM D compiler (1.35.0)
Default target: x86_64-unknown-linux-gnu
Host CPU: skylake-avx512
http://dlang.org - http://wiki.dlang.org/LDC
Registered Targets:
aarch64 - AArch64 (little endian)
aarch64_32 - AArch64 (little endian ILP32)
aarch64_be - AArch64 (big endian)
amdgcn - AMD GCN GPUs
arm - ARM
arm64 - ARM64 (little endian)
arm64_32 - ARM64 (little endian ILP32)
armeb - ARM (big endian)
avr - Atmel AVR Microcontroller
bpf - BPF (host endian)
bpfeb - BPF (big endian)
bpfel - BPF (little endian)
hexagon - Hexagon
lanai - Lanai
loongarch32 - 32-bit LoongArch
loongarch64 - 64-bit LoongArch
mips - MIPS (32-bit big endian)
mips64 - MIPS (64-bit big endian)
mips64el - MIPS (64-bit little endian)
mipsel - MIPS (32-bit little endian)
msp430 - MSP430 [experimental]
nvptx - NVIDIA PTX 32-bit
nvptx64 - NVIDIA PTX 64-bit
ppc32 - PowerPC 32
ppc32le - PowerPC 32 LE
ppc64 - PowerPC 64
ppc64le - PowerPC 64 LE
r600 - AMD GPUs HD2XXX-HD6XXX
riscv32 - 32-bit RISC-V
riscv64 - 64-bit RISC-V
sparc - Sparc
sparcel - Sparc LE
sparcv9 - Sparc V9
spirv32 - SPIR-V 32-bit
spirv64 - SPIR-V 64-bit
systemz - SystemZ
thumb - Thumb
thumbeb - Thumb (big endian)
ve - VE
wasm32 - WebAssembly 32-bit
wasm64 - WebAssembly 64-bit
x86 - 32-bit X86: Pentium-Pro and above
x86-64 - 64-bit X86: EM64T and AMD64
xcore - XCore
Upgrading project in /home/runner/work/libdparse/libdparse/
Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.35.0/x64/ldc2-1.35.0-linux-x86_64/bin/ldc2 for x86_64.
Building libdparse 0.23.2+commit.9.ge91e786: building configuration [library]
STAT:------ libdparse statistics ------
STAT:
STAT:statistics (-before, +after)
STAT:library size=3197196 libdparse.a
STAT:rough build time=16s
STAT:
STAT:
STAT:------ DCD statistics ------
STAT:
{
"name": "dcd",
"description": "The D Completion Daemon is an auto-complete program for the D programming language",
"copyright": "Copyright © 2015-2020, Brian Schott",
"authors": [
"Brian Schott"
],
"license": "GPL-3.0",
"dependencies": {
":dsymbol": "*",
"libdparse": {"path":".."},
":common": "*",
"emsi_containers": "~>0.9.0"
},
"subPackages": ["dsymbol", "common"],
"versions": ["built_with_dub"],
"configurations": [
{
"name": "library",
"targetType": "library",
"excludedSourceFiles": [
"src/dcd/client/*",
"src/dcd/server/main.d"
]
},
{
"name": "client",
"targetType": "executable",
"targetPath": "bin/",
"targetName": "dcd-client",
"excludedSourceFiles": [
"src/dcd/server/*"
]
},
{
"name": "server",
"targetType": "executable",
"targetPath": "bin/",
"targetName": "dcd-server",
"excludedSourceFiles": [
"src/dcd/client/*"
]
}
]
}
{
"fileVersion": 1,
"versions": {
"dsymbol": "0.14.1",
"emsi_containers": "0.9.0",
"libdparse": {"path":".."},
"msgpack-d": "1.0.4",
"stdx-allocator": "2.77.5"
}
}
STAT:statistics (-before, +after)
STAT:client size=1048544 bin/dcd-client
STAT:server size=3115384 bin/dcd-server
STAT:rough build time=74s
STAT:
[33munix:tc001:[0m ... [32mPass[0m
[33munix:tc002:[0m ... [32mPass[0m
[33munix:tc003:[0m ... [32mPass[0m
[33munix:tc004:[0m ... [32mPass[0m
[33munix:tc005:[0m ... [32mPass[0m
[33munix:tc006:[0m ... [32mPass[0m
[33munix:tc007:[0m ... [32mPass[0m
[33munix:tc008:[0m ... [32mPass[0m
[33munix:tc009:[0m ... [32mPass[0m
[33munix:tc010:[0m ... [32mPass[0m
[33munix:tc011:[0m ... [32mPass[0m
[33munix:tc012:[0m ... [32mPass[0m
[33munix:tc013:[0m ... [32mPass[0m
[33munix:tc014:[0m ... [32mPass[0m
[33munix:tc015:[0m ... [32mPass[0m
[33munix:tc016:[0m ... [32mPass[0m
[33munix:tc017:[0m ... [32mPass[0m
[33munix:tc018:[0m ... [32mPass[0m
[33munix:tc019:[0m ... [32mPass[0m
[33munix:tc020:[0m ... [32mPass[0m
[33munix:tc021:[0m ... [32mPass[0m
[33munix:tc022:[0m ... [32mPass[0m
[33munix:tc023:[0m ... [32mPass[0m
[33munix:tc024:[0m ... [32mPass[0m
[33munix:tc025:[0m ... [32mPass[0m
[33munix:tc026:[0m ... [32mPass[0m
[33munix:tc027:[0m ... [32mPass[0m
[33munix:tc028:[0m ... [32mPass[0m
[33munix:tc029:[0m ... [32mPass[0m
[33munix:tc030:[0m ... [32mPass[0m
[33munix:tc031:[0m ... [32mPass[0m
[33munix:tc032:[0m ... [32mPass[0m
[33munix:tc033:[0m ... [32mPass[0m
[33munix:tc034:[0m ... [32mPass[0m
[33munix:tc035:[0m ... [32mPass[0m
[33munix:tc036:[0m ... [32mPass[0m
[33munix:tc037:[0m ... [32mPass[0m
[33munix:tc038:[0m ... [32mPass[0m
[33munix:tc039:[0m ... [32mPass[0m
[33munix:tc040:[0m ... [32mPass[0m
[33munix:tc041:[0m ... [32mPass[0m
[33munix:tc042:[0m ... [32mPass[0m
[33munix:tc043:[0m ... [32mPass[0m
[33munix:tc044:[0m ... [32mPass[0m
[33munix:tc045:[0m ... [32mPass[0m
[33munix:tc046:[0m ... [32mPass[0m
[33munix:tc047:[0m ... [32mPass[0m
[33munix:tc048:[0m ... [32mPass[0m
[33munix:tc049:[0m ... [32mPass[0m
[33munix:tc050:[0m ... [32mPass[0m
[33munix:tc051:[0m ... [32mPass[0m
[33munix:tc052:[0m ... [32mPass[0m
[33munix:tc053:[0m ... [32mPass[0m
[33munix:tc054:[0m ... [32mPass[0m
[33munix:tc055:[0m ... [32mPass[0m
[33munix:tc056:[0m ... [32mPass[0m
[33munix:tc057:[0m ... [32mPass[0m
[33munix:tc058:[0m ... [32mPass[0m
[33munix:tc059:[0m ... [32mPass[0m
[33munix:tc060:[0m ... [32mPass[0m
[33munix:tc061:[0m ... [32mPass[0m
[33munix:tc062:[0m ... [32mPass[0m
[33munix:tc620:[0m ... [32mPass[0m
[33munix:tc717:[0m ... [32mPass[0m
[33munix:tc_access_modifiers:[0m ... [32mPass[0m
[33munix:tc_accesschain_type:[0m ... [32mPass[0m
[33munix:tc_anon_class:[0m ... [32mPass[0m
[33munix:tc_anon_struct:[0m ... [32mPass[0m
[33munix:tc_bang_op_or_template:[0m ... [32mPass[0m
[33munix:tc_base_template_type:[0m ... [32mPass[0m
[33munix:tc_body_var:[0m ... [32mPass[0m
[33munix:tc_calltip_in_func:[0m ... [32mPass[0m
[33munix:tc_char_dot:[0m ... [32mPass[0m
[33munix:tc_complete_kw:[0m ... [32mPass[0m
[33munix:tc_ctors:[0m ... [32mPass[0m
[33munix:tc_currmod_fqn:[0m ... [32mPass[0m
[33munix:tc_ditto_scopes:[0m ... [32mPass[0m
[33munix:tc_empty_module:[0m ... [32mPass[0m
00000[33munix:tc_empty_requests:[0m ... [32mPass[0m
[33munix:tc_erroneous_body_content:[0m ... [32mPass[0m
[33munix:tc_extended_ditto:[0m ... [32mPass[0m
[33munix:tc_extended_types:[0m ... [32mPass[0m
[33munix:tc_if_auto_array:[0m ... [32mPass[0m
[33munix:tc_if_var:[0m ... [32mPass[0m
[33munix:tc_import_symbol_list:[0m ... [32mPass[0m
[33munix:tc_incomplete_switch:[0m ... [32mPass[0m
[33munix:tc_issue558:[0m ... [32mPass[0m
[33munix:tc_locate_ufcs_function:[0m ... [32mPass[0m
[33munix:tc_middle_of_utf:[0m ... [32mPass[0m
[33munix:tc_module_scope_op:[0m ... [32mPass[0m
[33munix:tc_named_mixin:[0m ... [32mPass[0m
[33munix:tc_opaque_structs:[0m ... [32mPass[0m
[33munix:tc_pointer_type_printing:[0m ... [32mPass[0m
[33munix:tc_pointers:[0m ... [32mPass[0m
[33munix:tc_recursive_public_import:[0m ... [32mPass[0m
[33munix:tc_rm_import:[0m ... [32mPass[0m
[33munix:tc_scope_mess:[0m ... [32mPass[0m
[33munix:tc_selective_import_list:[0m ... [32mPass[0m
[33munix:tc_super_scope:[0m ... [32mPass[0m
[33munix:tc_template_bang_completion:[0m ... [32mPass[0m
[33munix:tc_template_param_props:[0m ... [32mPass[0m
[33munix:tc_traits:[0m ... [32mPass[0m
[33munix:tc_ufcs_alias_this_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_array_type_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_calltip_in_func:[0m ... [32mPass[0m
[33munix:tc_ufcs_fundamental_types_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_pointer_type_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_string_and_string_literal_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_struct_completion:[0m ... [32mPass[0m
STAT:DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.43
STAT:DCD run_tests.sh Maximum resident set size (kbytes): 41324
STAT:
STAT:short requests: (230x)
STAT: min request time = 0.013ms
STAT: 10th percentile = 0.116ms
STAT: median time = 0.434ms
STAT: 90th percentile = 0.753ms
STAT: max request time = 1.557ms
STAT:
STAT:long requests over 10ms: (51x)
STAT: min request time = 16.499ms
STAT: 10th percentile = 17.705ms
STAT: median time = 18.483ms
STAT: 90th percentile = 20.505ms
STAT: max request time = 29.069ms
STAT:
[33munix:tc001:[0m ... [32mPass[0m
[33munix:tc002:[0m ... [32mPass[0m
[33munix:tc003:[0m ... [32mPass[0m
[33munix:tc004:[0m ... [32mPass[0m
[33munix:tc005:[0m ... [32mPass[0m
[33munix:tc006:[0m ... [32mPass[0m
[33munix:tc007:[0m ... [32mPass[0m
[33munix:tc008:[0m ... [32mPass[0m
[33munix:tc009:[0m ... [32mPass[0m
[33munix:tc010:[0m ... [32mPass[0m
[33munix:tc011:[0m ... [32mPass[0m
[33munix:tc012:[0m ... [32mPass[0m
[33munix:tc013:[0m ... [32mPass[0m
[33munix:tc014:[0m ... [32mPass[0m
[33munix:tc015:[0m ... [32mPass[0m
[33munix:tc016:[0m ... [32mPass[0m
[33munix:tc017:[0m ... [32mPass[0m
[33munix:tc018:[0m ... [32mPass[0m
[33munix:tc019:[0m ... [32mPass[0m
[33munix:tc020:[0m ... [32mPass[0m
[33munix:tc021:[0m ... [32mPass[0m
[33munix:tc022:[0m ... [32mPass[0m
[33munix:tc023:[0m ... [32mPass[0m
[33munix:tc024:[0m ... [32mPass[0m
[33munix:tc025:[0m ... [32mPass[0m
[33munix:tc026:[0m ... [32mPass[0m
[33munix:tc027:[0m ... [32mPass[0m
[33munix:tc028:[0m ... [32mPass[0m
[33munix:tc029:[0m ... [32mPass[0m
[33munix:tc030:[0m ... [32mPass[0m
[33munix:tc031:[0m ... [32mPass[0m
[33munix:tc032:[0m ... [32mPass[0m
[33munix:tc033:[0m ... [32mPass[0m
[33munix:tc034:[0m ... [32mPass[0m
[33munix:tc035:[0m ... [32mPass[0m
[33munix:tc036:[0m ... [32mPass[0m
[33munix:tc037:[0m ... [32mPass[0m
[33munix:tc038:[0m ... [32mPass[0m
[33munix:tc039:[0m ... [32mPass[0m
[33munix:tc040:[0m ... [32mPass[0m
[33munix:tc041:[0m ... [32mPass[0m
[33munix:tc042:[0m ... [32mPass[0m
[33munix:tc043:[0m ... [32mPass[0m
[33munix:tc044:[0m ... [32mPass[0m
[33munix:tc045:[0m ... [32mPass[0m
[33munix:tc046:[0m ... [32mPass[0m
[33munix:tc047:[0m ... [32mPass[0m
[33munix:tc048:[0m ... [32mPass[0m
[33munix:tc049:[0m ... [32mPass[0m
[33munix:tc050:[0m ... [32mPass[0m
[33munix:tc051:[0m ... [32mPass[0m
[33munix:tc052:[0m ... [32mPass[0m
[33munix:tc053:[0m ... [32mPass[0m
[33munix:tc054:[0m ... [32mPass[0m
[33munix:tc055:[0m ... [32mPass[0m
[33munix:tc056:[0m ... [32mPass[0m
[33munix:tc057:[0m ... [32mPass[0m
[33munix:tc058:[0m ... [32mPass[0m
[33munix:tc059:[0m ... [32mPass[0m
[33munix:tc060:[0m ... [32mPass[0m
[33munix:tc061:[0m ... [32mPass[0m
[33munix:tc062:[0m ... [32mPass[0m
[33munix:tc620:[0m ... [32mPass[0m
[33munix:tc717:[0m ... [32mPass[0m
[33munix:tc_access_modifiers:[0m ... [32mPass[0m
[33munix:tc_accesschain_type:[0m ... [32mPass[0m
[33munix:tc_anon_class:[0m ... [32mPass[0m
[33munix:tc_anon_struct:[0m ... [32mPass[0m
[33munix:tc_bang_op_or_template:[0m ... [32mPass[0m
[33munix:tc_base_template_type:[0m ... [32mPass[0m
[33munix:tc_body_var:[0m ... [32mPass[0m
[33munix:tc_calltip_in_func:[0m ... [32mPass[0m
[33munix:tc_char_dot:[0m ... [32mPass[0m
[33munix:tc_complete_kw:[0m ... [32mPass[0m
[33munix:tc_ctors:[0m ... [32mPass[0m
[33munix:tc_currmod_fqn:[0m ... [32mPass[0m
[33munix:tc_ditto_scopes:[0m ... [32mPass[0m
[33munix:tc_empty_module:[0m ... [32mPass[0m
00000[33munix:tc_empty_requests:[0m ... [32mPass[0m
[33munix:tc_erroneous_body_content:[0m ... [32mPass[0m
[33munix:tc_extended_ditto:[0m ... [32mPass[0m
[33munix:tc_extended_types:[0m ... [32mPass[0m
[33munix:tc_if_auto_array:[0m ... [32mPass[0m
[33munix:tc_if_var:[0m ... [32mPass[0m
[33munix:tc_import_symbol_list:[0m ... [32mPass[0m
[33munix:tc_incomplete_switch:[0m ... [32mPass[0m
[33munix:tc_issue558:[0m ... [32mPass[0m
[33munix:tc_locate_ufcs_function:[0m ... [32mPass[0m
[33munix:tc_middle_of_utf:[0m ... [32mPass[0m
[33munix:tc_module_scope_op:[0m ... [32mPass[0m
[33munix:tc_named_mixin:[0m ... [32mPass[0m
[33munix:tc_opaque_structs:[0m ... [32mPass[0m
[33munix:tc_pointer_type_printing:[0m ... [32mPass[0m
[33munix:tc_pointers:[0m ... [32mPass[0m
[33munix:tc_recursive_public_import:[0m ... [32mPass[0m
[33munix:tc_rm_import:[0m ... [32mPass[0m
[33munix:tc_scope_mess:[0m ... [32mPass[0m
[33munix:tc_selective_import_list:[0m ... [32mPass[0m
[33munix:tc_super_scope:[0m ... [32mPass[0m
[33munix:tc_template_bang_completion:[0m ... [32mPass[0m
[33munix:tc_template_param_props:[0m ... [32mPass[0m
[33munix:tc_traits:[0m ... [32mPass[0m
[33munix:tc_ufcs_alias_this_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_array_type_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_calltip_in_func:[0m ... [32mPass[0m
[33munix:tc_ufcs_fundamental_types_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_pointer_type_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_string_and_string_literal_completion:[0m ... [32mPass[0m
[33munix:tc_ufcs_struct_completion:[0m ... [32mPass[0m
STAT:top 5 GC sources in server:
STAT:bytes allocated, allocations, type, function, file:line
STAT: 78109696 843 void[] std.array.Appender!(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;")[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
STAT: 15257216 476788 void[] core.lifetime._d_newitemT!(Data)._d_newitemT /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/druntime/import/core/lifetime.d:2833
STAT: 14316800 164422 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3634
STAT: 9773344 305417 Data std.array.Appender!string.Appender.this /opt/hostedtoolcache/dc/dmd-2.105.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3509
STAT: 7372208 281 ubyte[] msgpack.unpacker.Unpacker.InternalBuffer!().initializeBuffer ../../../../.dub/packages/msgpack-d/1.0.4/msgpack-d/src/msgpack/common.d:628
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #510 (bdd87a6) into master (63556f0) will increase coverage by
0.08%. The diff coverage is88.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 84.25% 84.34% +0.08%
==========================================
Files 11 11
Lines 8561 8776 +215
==========================================
+ Hits 7213 7402 +189
- Misses 1348 1374 +26
| Files | Coverage Δ | |
|---|---|---|
| src/dparse/astprinter.d | 95.00% <100.00%> (+0.05%) |
:arrow_up: |
| src/dparse/formatter.d | 48.85% <100.00%> (+0.66%) |
:arrow_up: |
| src/dparse/parser.d | 92.66% <86.11%> (-0.07%) |
:arrow_down: |
| src/dparse/lexer.d | 88.47% <93.38%> (+0.62%) |
:arrow_up: |
| src/dparse/ast.d | 68.97% <53.57%> (-0.72%) |
:arrow_down: |
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 63556f0...bdd87a6. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm all for merging this. I don't really have a good feel for what is the proper way to do these things, but we definitely need something. As noted from the linked bug reports, people are finding the lack of istring support troublesome, and it will only get worse. I think it is better to have a buggy or substandard implementation than no attempt.
Needs a rebase though...
Same idea as in the compiler.
The lexer has a mini parser that consumes tokens and spits out others.
It at least lines up.
Not sure this is still being worked on, but with this branch, iq{...} with line breaks in them are syntax errors, even though dmd accepts them just fine (as you would expect); q{...} with linebreaks parses fine.
enum foo = iq{
};
reports
foo.d(1:15)[error]: Expected `;` instead of EOF
i gotta get this into adrdox and the code looks ok to me, i gotta do adaptation to fit in my code but i think i can use most of it so ill let you know how it goes (though i avoid using new features in the libraries so it isn't going to be a very comprehensive test, still it is some)
can confirm the iq{ ... } ones are broken. I get a differnet error, but my branch divered back in 2016 so that's not gonna be too helpful (tbh im amazed most the patch applied automatically in my branch! the parser and formatter didn't, but those aren't important to adrdox anyway. and the lexer patch applied successfully and is mostly working).
Looks like the first { is not seen by the lexIstringPlain function. In lexInterpolatedString, it detects the case 'q' then does a range.popFront inside that switch. There's a second range.popFront below that consumes the { prematurely.
I suggest deleting the range.popFront inside of case 'q'.
Then in lexIstringPlain:
case '}':
if (istringStack[$ - 1].type == IstringState.Type.tokenString)
{
assert(istringStack[$ - 1].braces > 0);
istringStack[$ - 1].braces--;
// add this to recognize the end of the line
if(istringStack[$ - 1].braces == 0)
break Loop;
}
goto default;
but this fails:
auto a = iq{ "}" hi };
so i don't think this approach is correct at all really, it sh ould be running a child lexer inside the q{} thing.
Yeah, I think the best approach is to copy/paste from lexTokenString and inject checks for tok!"$" to do the escaping behavior instead of reading the bytes. Then the lexer will handle the quoted string and char literals correctly. That's pretty much what dmd does and it would work better here too.
tho tbh for now adrdox is just gonna leave it as a // FIXME cuz realistically this is better than nothing and im out of time to mess with it tonight.