active_material icon indicating copy to clipboard operation
active_material copied to clipboard

Font weights aren't variables

Open ShaunSpringer opened this issue 9 years ago • 3 comments

Font weights are scattered all over the various components, atoms, etc. These should be variables (or mixins). It makes it very difficult to use a thin font or custom weights!

ShaunSpringer avatar Sep 08 '16 13:09 ShaunSpringer

Ack! They aren't! Just curious, what parts are you customizing? I'd like to figure out if there are other variables we can expose to make customizing your admin easier.

nhunzaker avatar Sep 08 '16 17:09 nhunzaker

I mostly was focused on colors, font weight, and font names. (we use a light font for most of our typography)

ShaunSpringer avatar Oct 01 '16 17:10 ShaunSpringer

I've replaced all instances of font weights with font variables. I've also updated the customization doc to include our font variables:

https://github.com/vigetlabs/active_material/blob/master/docs/customization.md#font-variables

On a component-by-component basis, a lot of variables are defined at the top of each file to allow for overides: https://github.com/vigetlabs/active_material/tree/master/app/assets/stylesheets/active_material/components

nhunzaker avatar Mar 29 '17 11:03 nhunzaker