WrappingHStack icon indicating copy to clipboard operation
WrappingHStack copied to clipboard
verified publisher icon dkk

Crash on iOS 16 beta 3

Open GiovanniE1993 opened this issue 3 years ago • 10 comments

Using a WrappingHStack the iOS app on iOS 16 beta 3 will crash.

To reproduce you can open a view with a WrappingHStack inside.

  • WrappingHStack version: 2.2.1
  • Model: iPad Pro and iPhone XR
  • OS: iOS 16 beta 3

GiovanniE1993 avatar Jul 14 '22 14:07 GiovanniE1993

Does WrappingHStack still crash on the current iOS 16 beta?

TDWog411 avatar Sep 02 '22 00:09 TDWog411

I've swtiched to https://github.com/globulus/swiftui-flow-layout in the meantime, so unfortunately I don't have a project ready to test it

ptxmac avatar Sep 05 '22 11:09 ptxmac

This is still present on the iOS 16 Release Candidate. Looks like any apps that use a WrappingHStack will freeze on iOS 16.

Nathan-Molby avatar Sep 08 '22 14:09 Nathan-Molby

I'm on a trip right now, I will try to fix it when I'm back. I would be happy for some help so we can fix the issue sooner.

dkk avatar Sep 08 '22 18:09 dkk

Thanks for the update. I will avoid using it in my current app.

TDWog411 avatar Sep 09 '22 00:09 TDWog411

FWIW same issue on the public iOS 16 release - crash/freeze seems to happen on this line: https://github.com/dkk/WrappingHStack/blob/3a66fa48441e972d7817c1157d3c0a826e963797/Sources/WrappingHStack/InternalWrappingHStack.swift#L34

This is almost certainly an iOS bug, but I wonder if there are any good workarounds...

rubencodes avatar Sep 12 '22 19:09 rubencodes

I cannot reproduce it, can someone with this problem please share following information:

  • Does it happen on device only or device and simulator?
  • What devices/simulators have you tested?
  • Which Xcode & iOS version where you using?
  • Does the example app crash?
  • Add a minimal, reproducible example

dkk avatar Sep 15 '22 12:09 dkk

This is still present on the iOS 16 Release Candidate. Looks like any apps that use a WrappingHStack will freeze on iOS 16.

It does not seem to be an issue on the final iOS 16 release as far as I can tell, in case someone still has an issue, please reopen stating the information from my previous comment

dkk avatar Sep 15 '22 13:09 dkk

It is happening in our App. So far what I can see is that the closure of GeometryReader in the class WrappingHStack is being called over and over causing the UI to freeze. (Careful, the closure of GeometryReader is being called, not the body of the WrappingHStack struct (which is called the normal amount of times))

Does it happen on device only or device and simulator?

Can't run my project on the simulator because a limitation of one of my dependencies (TensorFlow lite). It is happening on an iPhone 13 Pro with iOS 16.0 (20A362)

What devices/simulators have you tested?

Just one iPhone 13 Pro

Which Xcode & iOS version where you using?

iOS 16.0 (20A362), Xcode 14.0

Does the example app crash?

No

Add a minimal, reproducible example

... Working on it as this is happening in a complex app

tomacco avatar Sep 20 '22 11:09 tomacco

It seems this is a minimum reproducible example: https://github.com/dkk/WrappingHStack/issues/26

hervenivon avatar Sep 21 '22 11:09 hervenivon