keeperfx icon indicating copy to clipboard operation
keeperfx copied to clipboard

Fix SET_CREATURE_PROPERTY not correctly clearing all flag

Open walt253 opened this issue 1 year ago • 3 comments

SET_CREATURE_PROPERTY clear creature property flag instead of toggling them.

walt253 avatar Apr 26 '24 06:04 walt253

We have clear_flag for this now

Loobinex avatar Apr 26 '24 14:04 Loobinex

We have clear_flag for this now

I'm not sure what you mean here? 🤔

Maybe eventually for when this script command get refactored for the new way of doing them? 🤔

Worth noting not all properties are flags, some are booleans. 🤔

walt253 avatar Apr 26 '24 17:04 walt253

I'm not sure what you mean here? 🤔

Instead of crconf->model_flags &= ~CMF_IsArachnid;

You could do clear_flag(crconf->model_flags,CMF_IsArachnid)

Loobinex avatar Apr 26 '24 18:04 Loobinex

@walt253 I did the suggested change myself. Agreed?

Loobinex avatar May 01 '24 21:05 Loobinex

@walt253 I did the suggested change myself. Agreed?

yes 👍 and sorry I completly forgot about that PR

walt253 avatar May 01 '24 23:05 walt253