Robert Lechte comments

Results 88 comments of


                                            Robert Lechte

Properly create triggers with status other than the default "origin".

Hi there, thanks so much for submitting this PR, and sorry it's taken me a while to getting to review. All looks great apart from a couple of minor typos,...

Add support for exclusion constraints

Awesome, thanks so much for contributing this! Have given it a brief lookover and all looks good, can hopefully give it a more detailed review later today and then merge.

Build improvements

Sorry for a my slow response on this. If you're willing to change the build script accordingly I'd be happy to add support for pypy to the tests.

When iterating over a `stream`ed response with amt=None, entire response is returned instead of streaming

Hey, just wondering about the status of this one? It sounds like v2 is not far away, now might be an opportune time to incorporate changes on this (assuming this...

Automate docker releases/tagging

I've now pushed the latest version to docker hub - and hope to add automated releases for this shortly.

Exclude constraint gets incorrectly created when multiple operations are present.

Closing as duplicate.

Exclusion constraint missing from diff

Exclusion constraints are now supported!

Unable to generate diff for 2 Postgres Database using migra

This bug should be fixed as of the latest `schemainspect` release.

self.enums is empty, migra throwing KeyError

This should at least not throw an error now. I'll create a separate ticket for including extension-owned objects in inspected data.

Add support for exclusion constraints

This code, with some minor mods, is now added. Thanks so much for contributing this!