Sound-Physics icon indicating copy to clipboard operation
Sound-Physics copied to clipboard

[Issue-1.12] Incompatibility with Valkyrien Skies

Open gatoborrachon opened this issue 4 years ago • 1 comments

What is happening When you use Sound Physics and Valkyrien Skies at the same time, you will not be able to "Assemble" Valkyrien Skies Ships

Steps to reproduce

  1. Add Valkyrien Skies (with its 2 addons: VS Control and VS World) and Sound Physics

  2. Build a simple ship in the air (Just a wooden table, 4x1x4, like the following pic) 2021-10-23_17 55 31

  3. Put a Physics Infuser, a Captain's Chair and take a Physics Core (from its Creative Tab) and put it inside the Physics Infuser (like the following pictures) 1.- Physics Infuser and Captain's Chair 2021-10-23_17 55 45 2.- Physics Core inside the Physics Infuser 2021-10-23_17 55 57

  4. Try to Assemble this ship in the Physics Infuser by clicking the "Assemble Ship" Buttom 2021-10-23_17 56 01

Expected Behavior -The ship should be assembled, this means that you should be able to interact with its blocks, broke them, place new ones, etc (Like in this video:) https://www.youtube.com/watch?v=ORvdkAXYJEc

Actual Behavior -The Ship is a dead piece of blocks, you can't interact with it, nor dissasemble it 1.- I can't destroy blocks 2021-10-23_17 56 12

2.- I can't place blocks 2021-10-23_17 56 19

EDIT: -I just discovered that, if you go out and re-enter to the world, you will be able to interact 1 time with the ship (in the following pic i placed a block, but i can't place/destroy other again, unless i repeat this) 2021-10-23_17 56 42

Versions Forge: 14.23.5.2855 Sound Physics: 1.12.2-1.0.10-1 (The one you gave me in this comment) Valkyrien Skies: 1.1.7 Valkyrien Skies Control: 1.1.1 Valkyrien Skies World: 1.0.0

Additional Notes Well, as i said before, i have not had time to test the mods, i just found this incompatibility a few hours ago, so don't horry, there's no problem with the time (although i just would like to know if you think that this issue should be "easy" to fix, i had issues before with Valkyrien Skies, but at least these had a crash report (with a mod called Survival Inc.))

gatoborrachon avatar Oct 23 '21 23:10 gatoborrachon

Valkyrien Skies 1 has issues with sound originating from ship blocks due to a very aggressive thread check. Does the issue still persist with the Unvalkyried Heavens fork?

LordDarthDan avatar Dec 30 '24 18:12 LordDarthDan