code.djangoproject.com icon indicating copy to clipboard operation
code.djangoproject.com copied to clipboard

Format DSF text in copyright

Open priyapahwa opened this issue 1 year ago • 2 comments

  • Add space between Software Foundation
  • Underline links for DSF & registered trademark

priyapahwa avatar Feb 12 '24 16:02 priyapahwa

Hi and thanks for the pull request!

I'm impressed you spotted the missing space in the footer, I didn't know anyone actually read that 😅

For the underlining, I would prefer to do it in CSS instead of using <u> in the HTML. That will require modifying the file at scss/trachacks.scss. I've done a quick check and it seems we have two options:

  1. Add the underline in the a:link, a:visited selector near the beginning. This undoes the styling that Trac does on all links where it removes the underline, but has the consequence that almost all links now have an underline on the page. Personally I don't mind, but it does affect a lot of pages.
  2. Add a more restricted selector, maybe something like .footer a, or even .footer .copyright a. This fixes the lack of underline in the footer only, but has the slight disadvantage that it's yet another customization of the style that ideally would be handled only be output.css (which we originally copied from django/djangoproject.com).

Do you have an opinion on what would be the better option of the two? Or maybe a third idea?

Thanks! ✨

bmispelon avatar Feb 12 '24 18:02 bmispelon

Hey @bmispelon, Thanks for the detailed feedback. I'll look into this and get back to you in a while :)

priyapahwa avatar Feb 14 '24 20:02 priyapahwa