code.djangoproject.com icon indicating copy to clipboard operation
code.djangoproject.com copied to clipboard

trac "pull requests" entry disappears when editing

Open davidszotten opened this issue 10 years ago • 3 comments

Once i start typing in the "Comment" box and the preview appears, the "Pull Requests:" section of the summary box disappears.

Thought i was going crazy. Is this intentional?

davidszotten avatar Mar 16 '15 20:03 davidszotten

Yeah, I can reproduce this.

I don't think it's intentional. The pull request section is added client-side by a piece of javascript and I suspect that when Trac generates the "draft" view of the ticket, it gets overriden.

bmispelon avatar Mar 16 '15 22:03 bmispelon

Not easily fixed I'd guess, and probably not worth it, IMO.

timgraham avatar Mar 16 '15 22:03 timgraham

The code that does the "draft" thing seems to be part of the "auto preview" trac plugin and can be found there: https://code.djangoproject.com/chrome/common/js/auto_preview.js

I suspect fixing this is just a matter of hooking into the right event and re-inserting the pull request information.

bmispelon avatar Mar 16 '15 22:03 bmispelon