PyAPNs icon indicating copy to clipboard operation
PyAPNs copied to clipboard

Upload New Version To PyPI

Open alliefitter opened this issue 7 years ago • 11 comments

Ref #63

The current version hosted on PyPi does not have the changes added in fce9e33c62a0cef8eebcd8b1a293d66be0b45480 which make the module compatible with Python 3. Uploading a new version would be greatly appreciated as this is the only maintained Python APNS library I've found. Thanks! (And thanks for maintaining this repository for so many years!)

alliefitter avatar Jun 27 '18 15:06 alliefitter

Sorry to bump this, but is there any ETA on a PyPi upload?

alliefitter avatar Nov 06 '18 16:11 alliefitter

I would also appreciate the Python 3 compatible version to be published!

Schnodderbalken avatar Nov 22 '18 12:11 Schnodderbalken

Hey, can we get an update to this @djacobs

laundry-96 avatar Jun 24 '19 22:06 laundry-96

I'm open to it, I've not been able to test. The diff appears innocuous. Can folks confirm this is working in production and passes tests?

I agree the right thing to do is to leave old Python behind.

djacobs avatar Jun 25 '19 16:06 djacobs

I'm currently in development stages of using this package for a software at work, so no clue what's going to happen. Currently using version 833b00f5c58a211d4a00ee4a0c41ca0a0e032270

laundry-96 avatar Jul 20 '19 15:07 laundry-96

Thanks @laundry-96 - let me know how it goes.

djacobs avatar Jul 23 '19 13:07 djacobs

I currently test it on python 3.6, and test failed

FAIL: testFrame (main.TestAPNs)

Traceback (most recent call last): File "tests.py", line 193, in testFrame self.assertTrue(f1 == frame.get_frame() or f2 == frame.get_frame()) AssertionError: False is not true

@djacobs

shiyuchong avatar Aug 02 '19 09:08 shiyuchong

and others just pass.

shiyuchong avatar Aug 02 '19 09:08 shiyuchong

OK, I have fixed the bug. just change the order in Payload.dict.

shiyuchong avatar Aug 02 '19 11:08 shiyuchong

Thanks, please make a pull request.

djacobs avatar Aug 02 '19 11:08 djacobs

@djacobs , Done. But I recommend you test it again in your own computer. I edit it on github, so there maybe problems like indent. Thanks for your work.

shiyuchong avatar Aug 02 '19 13:08 shiyuchong