FluidLite icon indicating copy to clipboard operation
FluidLite copied to clipboard
verified publisher icon divideconcept

Instrument loop points are ignored

Open mmontag opened this issue 3 years ago • 4 comments

Given:

  • Save a SoundFont 2.01 from Polyphone 2.3.1
  • Presets contains instrument defined loop point overrides: CleanShot 2022-10-23 at 14 59 18

Expected: Fluidlite plays smooth loop points as when previewing the Preset in Polyphone. Observed: Fluidlite plays the entire sample looped with popping noise.

Caveat: I am using a slightly older version of Fluidlite, please close if this has already been addressed.

cc @Wohlstand

mmontag avatar Oct 23 '22 22:10 mmontag

duplicated: #33

pedrolcl avatar Oct 23 '22 22:10 pedrolcl

Potential fix in FluidSynth: https://github.com/FluidSynth/fluidsynth/pull/1018/files Discussion: https://github.com/FluidSynth/fluidsynth/issues/1017

mmontag avatar Oct 24 '22 00:10 mmontag

For what it's worth, I fixed it locally by disabling this block:

https://github.com/divideconcept/FluidLite/blob/7c150b021f8b7e7d4f624bbad644fd2f96e5826b/src/fluid_defsfont.c#L3192-L3206

This seems to be an older version of the FluidSynth sanitize code linked above.

mmontag avatar Oct 24 '22 01:10 mmontag

This seems to be an older version of the FluidSynth sanitize code linked above.

That was removed in FluidSynth by PR#184

pedrolcl avatar Oct 24 '22 20:10 pedrolcl