diffusionbee-stable-diffusion-ui icon indicating copy to clipboard operation
diffusionbee-stable-diffusion-ui copied to clipboard
verified publisher icon divamgupta

Add text search in history

Open boredcity opened this issue 3 years ago • 4 comments

Resolves the issue https://github.com/divamgupta/diffusionbee-stable-diffusion-ui/issues/216

It would be amazing if you can add the "HACKTOBERFEST-ACCEPTED" label to the PR (that way it'll count toward my Hacktoberfest PRs https://hacktoberfest.com/participation/ 😅 )

image

boredcity avatar Oct 14 '22 11:10 boredcity

Any chance of fleshing out the commit beyond "init"? It will add a lot of color in future investigation work :) It also appears your username is not associated with your commit (try clicking your name in https://github.com/divamgupta/diffusionbee-stable-diffusion-ui/pull/220/commits/1ad6bfe02cd345debf97b7bea5301abeb336af01)

Leland avatar Oct 14 '22 12:10 Leland

Any chance of fleshing out the commit beyond "init"? It will add a lot of color in future investigation work :) It also appears your username is not associated with your commit (try clicking your name in 1ad6bfe)

Yeah, that makes sense :) Hopefully, both problems should be fixed now.

boredcity avatar Oct 14 '22 12:10 boredcity

Is there any way I can request a review for this PR? 🕵️

boredcity avatar Oct 18 '22 15:10 boredcity

Thanks for the PR. This is a useful feature. I will review it shortly.

divamgupta avatar Oct 20 '22 04:10 divamgupta

I have some comments:

  1. Lets remove extended search rules popover. It can be annoying. You could add a brief description in the docs
  2. Could you remove package-lock.json from pr
  3. Rn if you search for " " nothing comes up, maybe trim the text
  4. Maybe add "no search results" when there are no search results

Optional 5) if possible could you also add pagination in general. just simple next and prev button. (that could be separate PR)

divamgupta avatar Nov 06 '22 01:11 divamgupta