react-pirate

react-pirate copied to clipboard

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. Commits See full diff in compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter...

dependabot[bot]

Do `useInterval` and `useTimeout` re-initialize on every re-render?

7

I'm not sure if something changed in the API for `useEffect`, but I think that, if you omit the second argument, it will re-run the effect on every re-render.

vfonic

fix(useInterval): use a memoized function

2

By memoizing the function via `useCallback` within `useInterval`, coupled with the explicit cache of `[]` (meaning that the effect only has an onMount and onUnmount), only a single interval is...

ckknight

fix(useUnmount): use a memoized function

1

Because of the use of the `[]` cache, only the first function that was passed in would have been used during the unmount process. This ensures that the most recent...

ckknight

Tests

1

How would you like to do testing of `react-pirate`? My first inclination is to use `jest`, have a sibling file for each hook, e.g. `useMount.test.js`, and within there, make one...

ckknight

fix(ts): update Function types

1

This replaces the generalized `Function` with the more explicit `() => void`, which matches the actual API.

ckknight