Commando icon indicating copy to clipboard operation
Commando copied to clipboard

fix: replace resolveString with verifyString

Open monbrey opened this issue 4 years ago • 10 comments

Replaces a reference to the now removed Util.resolveString with Util.verifyString Introduced by https://github.com/discordjs/discord.js/pull/4880

monbrey avatar Jun 04 '21 11:06 monbrey

I just tested this PR and looks like this.options is giving the error TypeError: Cannot read property 'content' of undefined, without the this.options is working fine

ghost avatar Jun 04 '21 15:06 ghost

Shouldn't StringResolvable be Replaced with string in the Typings?

ghost avatar Jun 09 '21 00:06 ghost

StringResolvable is being used for message sending and editing, both of which are changing in https://github.com/discordjs/discord.js/pull/5758

Once the PR has landed, this can be updated and fix two breaking changes together.

kyranet avatar Jun 09 '21 00:06 kyranet

I don't believe this PR should address both changes, no. I will update the typing though.

monbrey avatar Jun 09 '21 00:06 monbrey

Oh, yeah mb, I thought this was a PR for updating Commando for v13.

kyranet avatar Jun 09 '21 07:06 kyranet

Oh, yeah mb, I thought this was a PR for updating Commando for v13.

There are a lot of things missing to support v13, This is getting kinda off-topic lets discuss on library-discussion if You want.

ghost avatar Jun 09 '21 22:06 ghost

can this be merged so we can use commando with the master version of discord.js

arifali123 avatar Jun 18 '21 21:06 arifali123

This PR just Broke lmao, now You get verifyString is not a function

ghost avatar Jun 29 '21 20:06 ghost

It's still in there: https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L403

Are you sure you didn't change back to 12.5.3?

kyranet avatar Jun 29 '21 20:06 kyranet

It's still in there: https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L403

Are you sure you didn't change back to 12.5.3?

Yea I didn't changed back to 12, He Just forgot to add .Util after requiring d.js

ghost avatar Jun 29 '21 20:06 ghost