examples upgrade sveltekit to v1

Upgrade Sveltekit example template to Sveltekit V1.0.0 which was just released.

Dec 15 '22 19:12 alexvdvalk

Yes it would be best to use the new way of importing environmental variables. This ensures that the DB credentials are not accidentally bundled into the front end app.

I didn't want to change too many things in the first instance

I can ammend and resubmit.

Dec 16 '22 10:12 alexvdvalk

@alexvdvalk I think it would be a good idea to the new way of importing env variables, outside of that everything looks good.

Dec 22 '22 13:12 freekrai

I've cleaned up the environment variables setup so that it uses Sveltekits native management. Also updated the readme and dotenv dependency.

Dec 22 '22 16:12 alexvdvalk

This has been super helpful. I'm still running through this upgrade on my end, but a couple of things:

.env.example is missing PUBLIC_DIRECTUS_URL so all connections fail currently
It looks like project structure may need a little more cleanup, especially around client/server hooks structure aka https://kit.svelte.dev/docs/project-structure -- migrating to hooks.*.js. I'm still new to sveltekit1 so apologies for not submitting changes and just commenting. But it does look like src/lib/client.js would need to become src/hooks.client.js?
Again, still new to sveltekit, but should the example be combining the private/server and public/client variables in same file (src/lib/client.js) or should they be separated into hooks.client.js and hooks.server.js?

Feb 17 '23 01:02 emilyf

Thanks for your comment. I have replaced the SECRET_DIRECTUS_URL with PUBLIC_DIRECTUS_URL in the .env.example file. I also moved the client.js into a server folder as explained at https://kit.svelte.dev/docs/server-only-modules

I don't think hooks are requiered in this demo.

Feb 17 '23 11:02 alexvdvalk

For what it's worth, this is looking and running great on my end! Looking forward to the merge.

Mar 23 '23 14:03 emilyf