sparkl icon indicating copy to clipboard operation
sparkl copied to clipboard

Update to bevy 0.12

Open ThierryBerger opened this issue 1 year ago • 0 comments

The main objective is to update to bevy 0.14.

I did try to make the full jump, but 99+ errors were overwhelming, so I'm splitting the work for each bevy version: this PR focuses on bevy 0.12, I'll list good references here and in comments:

  • migration guide: https://bevyengine.org/learn/migration-guides/0-11-to-0-12
  • instancing shader example from bevy, checking out specific bevy version is useful: https://github.com/bevyengine/bevy/blob/main/examples/shader/shader_instancing.rs#L155
Details

There was a bug with the 3d rendering as of 95d22b7fc6be2e4b21116d04b79601f00a6ab1c8: ; see https://github.com/dimforge/sparkl/pull/23#discussion_r1737057483 for investigation thread.

Screencast from 08-29-2024 12:05:00 PM.webm

Solved by passing the identity function rather than incorrect model matrix.

ThierryBerger avatar Aug 27 '24 19:08 ThierryBerger