action-doctl icon indicating copy to clipboard operation
action-doctl copied to clipboard

Handling beta releases and version mismatches for stable version

Open kishlay-singh-DO opened this issue 4 months ago • 2 comments

kishlay-singh-DO avatar Sep 24 '25 15:09 kishlay-singh-DO

fwiw, it would be better to internally standardize representing versions without the "v" prefix, then have a formatter singleton or the like that you can use to format it for different use cases. if this PR fixes the presenting issue, so be it, as the action is presently broken, but looking at the surrounding code does not inspire confidence

dkrieger avatar Sep 24 '25 19:09 dkrieger

fwiw, it would be better to internally standardize representing versions without the "v" prefix, then have a formatter singleton or the like that you can use to format it for different use cases. if this PR fixes the presenting issue, so be it, as the action is presently broken, but looking at the surrounding code does not inspire confidence

@dkrieger That is a good suggestion given github file path creates the link without the "v" prefix which was the major reason that the surrounding block has to be handled that way. The "v" prefix change will be a big change for us because that'll have to go to all open source tooling that we have. What part of it looks error prone to you, happy to fix it to make the code more robust.

kishlay-singh-DO avatar Sep 24 '25 20:09 kishlay-singh-DO