dbb-app icon indicating copy to clipboard operation
dbb-app copied to clipboard

Some fixes for depends builds.

Open randy-waterhouse opened this issue 8 years ago • 3 comments

Getting depends builds working again on linux required these fixes for me. Should be useful for others.

randy-waterhouse avatar Sep 04 '17 12:09 randy-waterhouse

Thanks and great to see you here! Will have a look soon.

jonasschnelli avatar Oct 11 '17 16:10 jonasschnelli

Ping @jonasschnelli, is there a reason these changes were not merged?

I was attempting to compile depends and hit the same issue recently, and was just about to submit a smaller PR (https://github.com/digitalbitbox/dbb-app/compare/master...hkjn:1807-remove-unknown-patch?expand=1) before finding this one.

Fwiw, with this PR or the one above, we get further but depends build still fails with:

fcmatch.c:284:63: error: 'PRI_CHAR_WIDTH_STRONG' undeclared here (not in a function); did you mean 'PRI_WIDTH_STRONG'?
 #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
                                                               ^
fcobjs.h:54:1: note: in expansion of macro 'FC_OBJECT'
 FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
 ^~~~~~~~~
fcmatch.c:284:84: error: 'PRI_CHAR_WIDTH_WEAK' undeclared here (not in a function); did you mean 'PRI_WIDTH_WEAK'?
 #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
                                                                                    ^
fcobjs.h:54:1: note: in expansion of macro 'FC_OBJECT'
 FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
 ^~~~~~~~~

hkjn avatar Jul 28 '18 16:07 hkjn

To follow up for any watchers curious about the PR (and issue #298) as well as for posterity, I found out via @benma that the new digitalbitbox app was just released:

  • https://github.com/digitalbitbox/bitbox-wallet-app

If I understand correctly, the bitbox-wallet-app is intended to fully replace dbb-app eventually.

hkjn avatar Aug 04 '18 07:08 hkjn