forge icon indicating copy to clipboard operation
forge copied to clipboard
verified publisher icon digitalbazaar

Replace bundled jsbn by the `jsbn` npm package

Open TimWolla opened this issue 6 years ago • 0 comments

This change makes it possible to interoperate forge's BigIntegers with other jsbn users. Previously this was not possible, due to a differently data layout introduced in digitalbazaar/forge#19.

See also: DefinitelyTyped/DefinitelyTyped#37012 DefinitelyTyped/DefinitelyTyped#33931

  • I have verified that the tests pass in node.js and within Google Chrome.
  • I do realize that this is a breaking change for anyone poking around in the internals of JSBN (the data array is gone).
  • I do realize that this is the first external dependency.
  • I propose this PR nonetheless to be able to discuss whether something like this is wanted.

TimWolla avatar Jul 23 '19 22:07 TimWolla