droid icon indicating copy to clipboard operation
droid copied to clipboard

No-profile mode doesn't escape commas in filenames

Open mistydemeo opened this issue 12 years ago • 1 comments

DROID uses commas to separate file paths from file IDs, but doesn't perform any escaping of the filename in the case that it contains a comma. For example:

$ droid -Nr /tmp/id -Ns ~/.droid6/signature_files/DROID_SignatureFile_V69.xml 2>/dev/null
DROID 6.1.2 No Profile mode: Runtime Information
Resource folder: /tmp/id
Binary signature file: /Users/vlcice/.droid6/signature_files/DROID_SignatureFile_V69.xml
Container signature file: None
Extension filter: No filter set
Recurse folders: False
Open archives: False
/private/tmp/id/foo,bar,Unknown

This renders the output somewhat ambiguous, though it's not too severe since the separator will always be the final comma.

It'd be nice if the filename's commas were escaped in this case. Since the output is vaguely CSV-like, maybe using quotes:

"/private/tmp/id/foo,bar",Unknown

mistydemeo avatar Aug 29 '13 21:08 mistydemeo

This issue has been added to the DROID backlog, it will be assigned an appropriate priority but is unlikely to be included in the next release.

paulyoung84 avatar Aug 08 '16 11:08 paulyoung84

This is fixed in 6.6.0

sparkhi avatar Mar 02 '23 17:03 sparkhi