designsystemet
designsystemet copied to clipboard
Figma, examples and information on some components is missing color-tokens or do not use the component
All component pages that include basiskomponenter
- Icon "lock", set to hex, could be more tidy if set to text-color token similar to the text beside it.
ToggleGroup
- "With only icons", the two blue icons is set to hex and not token
Textfield
- "Eksempel - Fjerne og legg til", icon is set to Icon/Default color for the light mode example, in the dark mode example the icon is set to the text default (neutral).
Table
- Sticky header example uses hex (white) as fill for table header, should probably use color token? This part has also detached the component.
Switch
- Only the top right example show both on/off variants as default, one in each pair should be changed to checked state.
Skip link
- Both versions include an transparent stroke, there is no property that allow this to be shown. If this is included because there is an invisible border in code that allow contrast mode/forced colors to show border, is it also needed in Figma, is there some other reason for the stroke?
Pagination and Button
- Parts of the examples is set using hex-colors, if these are changed to color-tokens, it will be possible to have more easy dark-mode examples built in.
ErrorSummary
- Parts of the examples use a fill for background set using hex, using tokens will allow easier dark-mode testing.
Chip
- Setting background (fill) for some of the examples to a background/surface color token will allow easier dark-mode testing.
Badge
- Setting icons to text-color will allow easier dark-mode examples
All
- Changing "browser preview examples" to use color tokens will allow easier switching between dark and light mode for all examples.