designsystemet icon indicating copy to clipboard operation
designsystemet copied to clipboard

feat: input with select and textbox

Open eirikbacker opened this issue 1 year ago • 3 comments

  • Adds select and textarea to #2550
  • Part of https://github.com/digdir/designsystemet/issues/2311
  • Select chevron, radio, checkbox and toggle adjustments are verified by Lasse

eirikbacker avatar Oct 04 '24 08:10 eirikbacker

🦋 Changeset detected

Latest commit: f95f9a82e3cf86f1787a1e216746205e3c2c2d7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-css Patch
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 04 '24 08:10 changeset-bot[bot]

Preview deployments for this pull request:

Storybook - 11. Oct 2024 - 12:15

Theme - 11. Oct 2024 - 12:16

github-actions[bot] avatar Oct 04 '24 08:10 github-actions[bot]

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 57.54% 3551 / 6171
🔵 Statements 57.54% 3551 / 6171
🔵 Functions 84.57% 159 / 188
🔵 Branches 76.11% 494 / 649
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/react/src/components/form/Select/Select.tsx 84.61% 50% 66.66% 84.61% 33-36
packages/react/src/components/form/Textarea/Textarea.tsx 100% 100% 100% 100%
Generated in workflow #317 for commit f95f9a8 by the Vitest Coverage Report Action

github-actions[bot] avatar Oct 08 '24 13:10 github-actions[bot]

Yes, completely moving towards Field-API, and leaving native elements as pure as possible avoiding anyt confusion on what is a <select> vs. <Select> 🙌

eirikbacker avatar Oct 11 '24 10:10 eirikbacker

Yes, completely moving towards Field-API, and leaving native elements as pure as possible avoiding anyt confusion on what is a <select> vs. <Select> 🙌

Sounds good, we just have to make sure we document it for people testing and using @next. I assume we will batch these changes into the same release anyways.

mimarz avatar Oct 11 '24 10:10 mimarz