designsystemet icon indicating copy to clipboard operation
designsystemet copied to clipboard

feat(Accordion): use native <details> element

Open eirikbacker opened this issue 1 year ago • 3 comments

  • Fixes #2100 🥳
  • Deprecates #2176
  • Built on top of <u-details> for better accessibility on mobile
  • Removes level from AccordionHeader as this is not supported by native <details>
  • Removes onHeaderClick from AccordionHeader as this is identical to adding a onClick handler
  • JS-based animation can be removed and replaced by CSS when calc-size(auto) is fully supported 🚀

Question: It is now implemented so search-in-page only works when using defaultOpen, as a controlled open should not be affected by user interaction. Just checking - does this make sense to you guys as well? :)

eirikbacker avatar Jul 29 '24 13:07 eirikbacker

⚠️ No Changeset found

Latest commit: 844b8505805fbb8eea2d48aeca41ab900844d06f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 29 '24 13:07 changeset-bot[bot]

Welcome back from vacay!

Thanks for making this, we'll have a look at this when the rest of the team is back :D

Just fyi, I am making some bigger architecture and ci improvements during the summer so things might be broken in next and/or so merge conflicts might arise 😅

mimarz avatar Jul 31 '24 06:07 mimarz

Thanks @mimarz :D No stress - not back until next week anyway here - looking forward to hear and learn about rewrites :) Hope summer was good!

eirikbacker avatar Jul 31 '24 16:07 eirikbacker

Closed as this will be replaced by #2363

eirikbacker avatar Sep 02 '24 12:09 eirikbacker