designsystemet icon indicating copy to clipboard operation
designsystemet copied to clipboard

Modal has wrong padding-bottom when Footer is removed

Open Thunear opened this issue 1 year ago • 1 comments

Description of the bug

When the Footer of the Modal component is removed the padding on the bottom is wrong in code. Should be equal all the way around.

Steps To Reproduce

Codesandbox: https://codesandbox.io/p/sandbox/laughing-currying-7wypvf

Additional Information

No response

Thunear avatar May 22 '24 15:05 Thunear

We would need to remove the padding-top on footer, but I don't see this a problem 🤔 When you use a header or a footer, content is in 99% of the cases there - so we can make some assumptions and move all the padding to Modal.Content.

We also have the possibility to extend the css, and check for what siblings the dialog has

Barsnes avatar May 22 '24 15:05 Barsnes

Test this again after #2295

mimarz avatar Sep 19 '24 07:09 mimarz