spotless icon indicating copy to clipboard operation
spotless copied to clipboard

Sortpom should fail instead of silently sort on spotless:check

Open tisonkun opened this issue 1 year ago • 3 comments

@Ekryd I'm trying to merge my sortpom config into spotless config build find that it doesn't failed on spotless:check but actually verifyFail == Sort.

I suppose we should use verifyFail == Stop so that it's the same manner as spotless.

Originally posted by @tisonkun in https://github.com/diffplug/spotless/issues/2049#issuecomment-2005605616

tisonkun avatar Mar 19 '24 02:03 tisonkun

@nedtwigg I'm not quite sure how check and format works (significant codepath).

I try to read the code but it's too dynamic to figure out. If you can describe the workflow perhaps I can try to work on a fix.

tisonkun avatar Mar 19 '24 02:03 tisonkun

My experience with Spotless is very limited, so I will hand this over to the kind folks that maintain spotless. 🎈

Ekryd avatar Mar 20 '24 19:03 Ekryd